summaryrefslogtreecommitdiffstats
path: root/Makefile
diff options
context:
space:
mode:
authorMarijn Suijten <marijn.suijten@somainline.org>2022-10-26 20:28:23 +0200
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>2022-11-04 17:39:41 +0300
commit0b55f6bc46be7a6f90ebae4666b7463b666958ee (patch)
tree4da5e9c75d9e170d3411d2a9a5c9a6211beeb82c /Makefile
parentd053fbc449c47517b1f6516dbce2f917f2a9f51d (diff)
downloadlinux-stable-0b55f6bc46be7a6f90ebae4666b7463b666958ee.tar.gz
linux-stable-0b55f6bc46be7a6f90ebae4666b7463b666958ee.tar.bz2
linux-stable-0b55f6bc46be7a6f90ebae4666b7463b666958ee.zip
drm/msm/dpu1: Account for DSC's bits_per_pixel having 4 fractional bits
According to the comment this DPU register contains the bits per pixel as a 6.4 fractional value, conveniently matching the contents of bits_per_pixel in struct drm_dsc_config which also uses 4 fractional bits. However, the downstream source this implementation was copy-pasted from has its bpp field stored _without_ fractional part. This makes the entire convoluted math obsolete as it is impossible to pull those 4 fractional bits out of thin air, by somehow trying to reuse the lowest 2 bits of a non-fractional bpp (lsb = bpp % 4??). The rest of the code merely attempts to keep the integer part a multiple of 4, which is rendered useless thanks to data |= dsc->bits_per_pixel << 12; already filling up those bits anyway (but not on downstream). Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Vinod Koul <vkoul@kernel.org> Patchwork: https://patchwork.freedesktop.org/patch/508946/ Link: https://lore.kernel.org/r/20221026182824.876933-10-marijn.suijten@somainline.org Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions