diff options
| author | Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2019-02-14 15:52:26 +0100 |
|---|---|---|
| committer | Sekhar Nori <nsekhar@ti.com> | 2019-02-19 20:03:36 +0530 |
| commit | 6c702da653d1a32e1410597f62b4f54ddaff1f9d (patch) | |
| tree | a225f60e17173fecd3e86ab4f2594ebf880a2492 /arch/arm | |
| parent | 9762d876af8afc26c721126348f54e5ec59ef2ff (diff) | |
| download | linux-stable-6c702da653d1a32e1410597f62b4f54ddaff1f9d.tar.gz linux-stable-6c702da653d1a32e1410597f62b4f54ddaff1f9d.tar.bz2 linux-stable-6c702da653d1a32e1410597f62b4f54ddaff1f9d.zip | |
ARM: davinci: cp-intc: unify error handling
Instead of dumping stack traces, just print a specific error message
in aintc driver.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Diffstat (limited to 'arch/arm')
| -rw-r--r-- | arch/arm/mach-davinci/cp_intc.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c index 25221dfe8a20..1bf11fa8be76 100644 --- a/arch/arm/mach-davinci/cp_intc.c +++ b/arch/arm/mach-davinci/cp_intc.c @@ -177,8 +177,10 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config, davinci_cp_intc_base = ioremap(config->reg.start, resource_size(&config->reg)); - if (WARN_ON(!davinci_cp_intc_base)) + if (!davinci_cp_intc_base) { + pr_err("%s: unable to ioremap register range\n", __func__); return -EINVAL; + } davinci_cp_intc_write(0, DAVINCI_CP_INTC_GLOBAL_ENABLE); @@ -210,8 +212,9 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config, irq_base = irq_alloc_descs(-1, 0, config->num_irqs, 0); if (irq_base < 0) { - pr_warn("Couldn't allocate IRQ numbers\n"); - irq_base = 0; + pr_err("%s: unable to allocate interrupt descriptors: %d\n", + __func__, irq_base); + return irq_base; } /* create a legacy host */ @@ -220,7 +223,7 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config, &davinci_cp_intc_irq_domain_ops, NULL); if (!davinci_cp_intc_irq_domain) { - pr_err("cp_intc: failed to allocate irq host!\n"); + pr_err("%s: unable to create an interrupt domain\n", __func__); return -EINVAL; } |