diff options
| author | Pavel Skripkin <paskripkin@gmail.com> | 2021-07-05 23:47:27 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-22 11:47:50 +0200 |
| commit | 161818ff30e696c3eec58a7617d38c9fd5889296 (patch) | |
| tree | 06950b92cbd92b09421446fcc6254851b0b16d18 /arch/m68k | |
| parent | f08721ee2b387cc0ba93f8c27e2e3a6be80db2e4 (diff) | |
| download | linux-stable-161818ff30e696c3eec58a7617d38c9fd5889296.tar.gz linux-stable-161818ff30e696c3eec58a7617d38c9fd5889296.tar.bz2 linux-stable-161818ff30e696c3eec58a7617d38c9fd5889296.zip | |
m68k: emu: Fix invalid free in nfeth_cleanup()
[ Upstream commit 761608f5cf70e8876c2f0e39ca54b516bdcb7c12 ]
In the for loop all nfeth_dev array members should be freed, not only
the first one. Freeing only the first array member can cause
double-free bugs and memory leaks.
Fixes: 9cd7b148312f ("m68k/atari: ARAnyM - Add support for network access")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/20210705204727.10743-1-paskripkin@gmail.com
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch/m68k')
| -rw-r--r-- | arch/m68k/emu/nfeth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index e45ce4243aaa..76262dc40e79 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -258,8 +258,8 @@ static void __exit nfeth_cleanup(void) for (i = 0; i < MAX_UNIT; i++) { if (nfeth_dev[i]) { - unregister_netdev(nfeth_dev[0]); - free_netdev(nfeth_dev[0]); + unregister_netdev(nfeth_dev[i]); + free_netdev(nfeth_dev[i]); } } free_irq(nfEtherIRQ, nfeth_interrupt); |