diff options
| author | Julia Lawall <Julia.Lawall@inria.fr> | 2023-09-07 11:55:16 +0200 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2023-09-18 12:23:26 +1000 |
| commit | 06b627c1236216ac1239c5e1afcc75359af3fb72 (patch) | |
| tree | 6ae4495777986e05edbf862ba82b965153dfc3b6 /arch/powerpc/kexec/file_load_64.c | |
| parent | a59e9eb25216eb1dc99e14fc31b76aa648d79540 (diff) | |
| download | linux-stable-06b627c1236216ac1239c5e1afcc75359af3fb72.tar.gz linux-stable-06b627c1236216ac1239c5e1afcc75359af3fb72.tar.bz2 linux-stable-06b627c1236216ac1239c5e1afcc75359af3fb72.zip | |
powerpc/kexec_file: add missing of_node_put
for_each_node_with_property performs an of_node_get on each
iteration, so a break out of the loop requires an
of_node_put.
This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230907095521.14053-7-Julia.Lawall@inria.fr
Diffstat (limited to 'arch/powerpc/kexec/file_load_64.c')
| -rw-r--r-- | arch/powerpc/kexec/file_load_64.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c index a3de5369d22c..09187aca3d1f 100644 --- a/arch/powerpc/kexec/file_load_64.c +++ b/arch/powerpc/kexec/file_load_64.c @@ -1138,11 +1138,15 @@ static int update_pci_dma_nodes(void *fdt, const char *dmapropname) continue; ret = copy_property(fdt, pci_offset, dn, "ibm,dma-window"); - if (ret < 0) + if (ret < 0) { + of_node_put(dn); break; + } ret = copy_property(fdt, pci_offset, dn, dmapropname); - if (ret < 0) + if (ret < 0) { + of_node_put(dn); break; + } } return ret; |