summaryrefslogtreecommitdiffstats
path: root/arch/powerpc/platforms/embedded6xx
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-11-20 20:33:19 +0000
committerMichael Ellerman <mpe@ellerman.id.au>2021-11-25 11:25:29 +1100
commitf6e82647ff71d427d4148964b71f239fba9d7937 (patch)
tree8308a27106e4bbb33264136178f78879c3267ea4 /arch/powerpc/platforms/embedded6xx
parentff0d6be4bf9ad4daba024ba0157b97750c7ad1fb (diff)
downloadlinux-stable-f6e82647ff71d427d4148964b71f239fba9d7937.tar.gz
linux-stable-f6e82647ff71d427d4148964b71f239fba9d7937.tar.bz2
linux-stable-f6e82647ff71d427d4148964b71f239fba9d7937.zip
powerpc/6xx: add missing of_node_put
for_each_compatible_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression e; local idexpression n; @@ @@ local idexpression n; expression e; @@ for_each_compatible_node(n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/1448051604-25256-2-git-send-email-Julia.Lawall@lip6.fr
Diffstat (limited to 'arch/powerpc/platforms/embedded6xx')
-rw-r--r--arch/powerpc/platforms/embedded6xx/hlwd-pic.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
index 15396333a90b..a4b020e4b6af 100644
--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
irq_set_chained_handler(cascade_virq,
hlwd_pic_irq_cascade);
hlwd_irq_host = host;
+ of_node_put(np);
break;
}
}