diff options
author | Matt Redfearn <matt.redfearn@mips.com> | 2018-01-29 11:26:45 +0000 |
---|---|---|
committer | James Hogan <jhogan@kernel.org> | 2018-02-05 13:32:17 +0000 |
commit | 0cde5b44a30f1daaef1c34e08191239dc63271c4 (patch) | |
tree | 78592fa5410294684d67f779b6e1a15efa933ca2 /arch/riscv | |
parent | 8dbc1864b74f5dea5a3f7c30ca8fd358a675132f (diff) | |
download | linux-stable-0cde5b44a30f1daaef1c34e08191239dc63271c4.tar.gz linux-stable-0cde5b44a30f1daaef1c34e08191239dc63271c4.tar.bz2 linux-stable-0cde5b44a30f1daaef1c34e08191239dc63271c4.zip |
MIPS: TXx9: use IS_BUILTIN() for CONFIG_LEDS_CLASS
When commit b27311e1cace ("MIPS: TXx9: Add RBTX4939 board support")
added board support for the RBTX4939, it added a call to
led_classdev_register even if the LED class is built as a module.
Built-in arch code cannot call module code directly like this. Commit
b33b44073734 ("MIPS: TXX9: use IS_ENABLED() macro") subsequently
changed the inclusion of this code to a single check that
CONFIG_LEDS_CLASS is either builtin or a module, but the same issue
remains.
This leads to MIPS allmodconfig builds failing when CONFIG_MACH_TX49XX=y
is set:
arch/mips/txx9/rbtx4939/setup.o: In function `rbtx4939_led_probe':
setup.c:(.init.text+0xc0): undefined reference to `of_led_classdev_register'
make: *** [Makefile:999: vmlinux] Error 1
Fix this by using the IS_BUILTIN() macro instead.
Fixes: b27311e1cace ("MIPS: TXx9: Add RBTX4939 board support")
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
Reviewed-by: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/18544/
Signed-off-by: James Hogan <jhogan@kernel.org>
Diffstat (limited to 'arch/riscv')
0 files changed, 0 insertions, 0 deletions