diff options
author | Song Liu <song@kernel.org> | 2023-09-18 23:02:57 -0700 |
---|---|---|
committer | Alexei Starovoitov <ast@kernel.org> | 2023-09-19 02:58:22 -0700 |
commit | cf094baa3e0f19f1f80ceaf205c80402b024386c (patch) | |
tree | 6bcc28b035de55dda452ce94b36f2d786714025e /arch/s390/net | |
parent | 8070274b472e2e9f5f67a990f5e697634c415708 (diff) | |
download | linux-stable-cf094baa3e0f19f1f80ceaf205c80402b024386c.tar.gz linux-stable-cf094baa3e0f19f1f80ceaf205c80402b024386c.tar.bz2 linux-stable-cf094baa3e0f19f1f80ceaf205c80402b024386c.zip |
s390/bpf: Let arch_prepare_bpf_trampoline return program size
arch_prepare_bpf_trampoline() for s390 currently returns 0 on success. This
is not a problem for regular trampoline. However, struct_ops relies on the
return value to advance "image" pointer:
bpf_struct_ops_map_update_elem() {
...
for_each_member(i, t, member) {
...
err = bpf_struct_ops_prepare_trampoline();
...
image += err;
}
}
When arch_prepare_bpf_trampoline returns 0 on success, all members of the
struct_ops will point to the same trampoline (the last one).
Fix this by returning the program size in arch_prepare_bpf_trampoline (on
success). This is the same behavior as other architectures.
Signed-off-by: Song Liu <song@kernel.org>
Fixes: 528eb2cb87bc ("s390/bpf: Implement arch_prepare_bpf_trampoline()")
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Link: https://lore.kernel.org/r/20230919060258.3237176-2-song@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'arch/s390/net')
-rw-r--r-- | arch/s390/net/bpf_jit_comp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c index de2fb12120d2..2861e3360aff 100644 --- a/arch/s390/net/bpf_jit_comp.c +++ b/arch/s390/net/bpf_jit_comp.c @@ -2513,7 +2513,7 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, return -E2BIG; } - return ret; + return tjit.common.prg; } bool bpf_jit_supports_subprog_tailcalls(void) |