diff options
author | Tong Zhang <ztong0001@gmail.com> | 2021-05-13 00:07:33 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-14 13:47:37 +0200 |
commit | 3ce3e45cc333da707d4d6eb433574b990bcc26f5 (patch) | |
tree | d30b89f396dd1e480ec5f6fdce3706853fed58df /arch/sparc | |
parent | 7272b591c4cb9327c43443f67b8fbae7657dd9ae (diff) | |
download | linux-stable-3ce3e45cc333da707d4d6eb433574b990bcc26f5.tar.gz linux-stable-3ce3e45cc333da707d4d6eb433574b990bcc26f5.tar.bz2 linux-stable-3ce3e45cc333da707d4d6eb433574b990bcc26f5.zip |
misc: alcor_pci: fix null-ptr-deref when there is no PCI bridge
There is an issue with the ASPM(optional) capability checking function.
A device might be attached to root complex directly, in this case,
bus->self(bridge) will be NULL, thus priv->parent_pdev is NULL.
Since alcor_pci_init_check_aspm(priv->parent_pdev) checks the PCI link's
ASPM capability and populate parent_cap_off, which will be used later by
alcor_pci_aspm_ctrl() to dynamically turn on/off device, what we can do
here is to avoid checking the capability if we are on the root complex.
This will make pdev_cap_off 0 and alcor_pci_aspm_ctrl() will simply
return when bring called, effectively disable ASPM for the device.
[ 1.246492] BUG: kernel NULL pointer dereference, address: 00000000000000c0
[ 1.248731] RIP: 0010:pci_read_config_byte+0x5/0x40
[ 1.253998] Call Trace:
[ 1.254131] ? alcor_pci_find_cap_offset.isra.0+0x3a/0x100 [alcor_pci]
[ 1.254476] alcor_pci_probe+0x169/0x2d5 [alcor_pci]
Co-developed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Link: https://lore.kernel.org/r/20210513040732.1310159-1-ztong0001@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch/sparc')
0 files changed, 0 insertions, 0 deletions