diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-11-30 18:03:44 +0100 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-12-02 22:55:49 +0800 |
commit | a6326ba025a4bc025c8c9a15ea2f307936a93843 (patch) | |
tree | b202228823f26c0452b882ffe12a1928ca549853 /arch/x86/crypto/sha512_ssse3_glue.c | |
parent | 8202cd720637e891639bf8e4af00d5431553c5b9 (diff) | |
download | linux-stable-a6326ba025a4bc025c8c9a15ea2f307936a93843.tar.gz linux-stable-a6326ba025a4bc025c8c9a15ea2f307936a93843.tar.bz2 linux-stable-a6326ba025a4bc025c8c9a15ea2f307936a93843.zip |
crypto: sha - replace memset by memzero_explicit
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
type T;
@@
{
... when any
T x[...];
... when any
when exists
- memset
+ memzero_explicit
(x,
-0,
...)
... when != x
when strict
}
// </smpl>
This change was suggested by Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'arch/x86/crypto/sha512_ssse3_glue.c')
-rw-r--r-- | arch/x86/crypto/sha512_ssse3_glue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/crypto/sha512_ssse3_glue.c b/arch/x86/crypto/sha512_ssse3_glue.c index 26a5898a6f26..0b6af26832bf 100644 --- a/arch/x86/crypto/sha512_ssse3_glue.c +++ b/arch/x86/crypto/sha512_ssse3_glue.c @@ -219,7 +219,7 @@ static int sha384_ssse3_final(struct shash_desc *desc, u8 *hash) sha512_ssse3_final(desc, D); memcpy(hash, D, SHA384_DIGEST_SIZE); - memset(D, 0, SHA512_DIGEST_SIZE); + memzero_explicit(D, SHA512_DIGEST_SIZE); return 0; } |