summaryrefslogtreecommitdiffstats
path: root/arch/x86/include/asm/dmi.h
diff options
context:
space:
mode:
authorNicolai Stange <nstange@suse.de>2018-07-29 12:15:33 +0200
committerThomas Gleixner <tglx@linutronix.de>2018-08-05 09:53:13 +0200
commit447ae316670230d7d29430e2cbf1f5db4f49d14c (patch)
tree9ab0392a39391993a79ec49f77c1ab26e8ff74a8 /arch/x86/include/asm/dmi.h
parent45b575c00d8e72d69d75dd8c112f044b7b01b069 (diff)
downloadlinux-stable-447ae316670230d7d29430e2cbf1f5db4f49d14c.tar.gz
linux-stable-447ae316670230d7d29430e2cbf1f5db4f49d14c.tar.bz2
linux-stable-447ae316670230d7d29430e2cbf1f5db4f49d14c.zip
x86: Don't include linux/irq.h from asm/hardirq.h
The next patch in this series will have to make the definition of irq_cpustat_t available to entering_irq(). Inclusion of asm/hardirq.h into asm/apic.h would cause circular header dependencies like asm/smp.h asm/apic.h asm/hardirq.h linux/irq.h linux/topology.h linux/smp.h asm/smp.h or linux/gfp.h linux/mmzone.h asm/mmzone.h asm/mmzone_64.h asm/smp.h asm/apic.h asm/hardirq.h linux/irq.h linux/irqdesc.h linux/kobject.h linux/sysfs.h linux/kernfs.h linux/idr.h linux/gfp.h and others. This causes compilation errors because of the header guards becoming effective in the second inclusion: symbols/macros that had been defined before wouldn't be available to intermediate headers in the #include chain anymore. A possible workaround would be to move the definition of irq_cpustat_t into its own header and include that from both, asm/hardirq.h and asm/apic.h. However, this wouldn't solve the real problem, namely asm/harirq.h unnecessarily pulling in all the linux/irq.h cruft: nothing in asm/hardirq.h itself requires it. Also, note that there are some other archs, like e.g. arm64, which don't have that #include in their asm/hardirq.h. Remove the linux/irq.h #include from x86' asm/hardirq.h. Fix resulting compilation errors by adding appropriate #includes to *.c files as needed. Note that some of these *.c files could be cleaned up a bit wrt. to their set of #includes, but that should better be done from separate patches, if at all. Signed-off-by: Nicolai Stange <nstange@suse.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/include/asm/dmi.h')
-rw-r--r--arch/x86/include/asm/dmi.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/include/asm/dmi.h b/arch/x86/include/asm/dmi.h
index 0ab2ab27ad1f..b825cb201251 100644
--- a/arch/x86/include/asm/dmi.h
+++ b/arch/x86/include/asm/dmi.h
@@ -4,8 +4,8 @@
#include <linux/compiler.h>
#include <linux/init.h>
+#include <linux/io.h>
-#include <asm/io.h>
#include <asm/setup.h>
static __always_inline __init void *dmi_alloc(unsigned len)