summaryrefslogtreecommitdiffstats
path: root/arch/x86/include/asm/microcode_amd.h
diff options
context:
space:
mode:
authorValdis Klētnieks <valdis.kletnieks@vt.edu>2019-12-05 22:44:33 -0500
committerBorislav Petkov <bp@suse.de>2019-12-12 22:29:00 +0100
commit82c881b28aa89215a760e39c5f6bcde2d6ce4918 (patch)
treec3ca28a49cefcbdf2fcd3d017b2f45bb0816449f /arch/x86/include/asm/microcode_amd.h
parente42617b825f8073569da76dc4510bfa019b1c35a (diff)
downloadlinux-stable-82c881b28aa89215a760e39c5f6bcde2d6ce4918.tar.gz
linux-stable-82c881b28aa89215a760e39c5f6bcde2d6ce4918.tar.bz2
linux-stable-82c881b28aa89215a760e39c5f6bcde2d6ce4918.zip
x86/microcode/AMD: Make stub function static inline
When building with C=1 W=1 (and when CONFIG_MICROCODE_AMD=n, as Luc Van Oostenryck correctly points out) both sparse and gcc complain: CHECK arch/x86/kernel/cpu/microcode/core.c ./arch/x86/include/asm/microcode_amd.h:56:6: warning: symbol \ 'reload_ucode_amd' was not declared. Should it be static? CC arch/x86/kernel/cpu/microcode/core.o In file included from arch/x86/kernel/cpu/microcode/core.c:36: ./arch/x86/include/asm/microcode_amd.h:56:6: warning: no previous \ prototype for 'reload_ucode_amd' [-Wmissing-prototypes] 56 | void reload_ucode_amd(void) {} | ^~~~~~~~~~~~~~~~ And they're right - that function can be a static inline like its brethren. Signed-off-by: Valdis Klētnieks <valdis.kletnieks@vt.edu> Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> Cc: x86@kernel.org Link: https://lkml.kernel.org/r/52170.1575603873@turing-police
Diffstat (limited to 'arch/x86/include/asm/microcode_amd.h')
-rw-r--r--arch/x86/include/asm/microcode_amd.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/include/asm/microcode_amd.h b/arch/x86/include/asm/microcode_amd.h
index 209492849566..6685e1218959 100644
--- a/arch/x86/include/asm/microcode_amd.h
+++ b/arch/x86/include/asm/microcode_amd.h
@@ -53,6 +53,6 @@ static inline void __init load_ucode_amd_bsp(unsigned int family) {}
static inline void load_ucode_amd_ap(unsigned int family) {}
static inline int __init
save_microcode_in_initrd_amd(unsigned int family) { return -EINVAL; }
-void reload_ucode_amd(void) {}
+static inline void reload_ucode_amd(void) {}
#endif
#endif /* _ASM_X86_MICROCODE_AMD_H */