summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorHe Zhe <zhe.he@windriver.com>2021-02-23 16:25:34 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-03-04 09:39:55 +0100
commit606655cd15af53fe287468fac47f617b927216ac (patch)
tree38d7fa0fb1f8afdf8401fe0988961a4ddcc455fa /arch
parentcc744d02593646893fd28532bed01d72543836f8 (diff)
downloadlinux-stable-606655cd15af53fe287468fac47f617b927216ac.tar.gz
linux-stable-606655cd15af53fe287468fac47f617b927216ac.tar.bz2
linux-stable-606655cd15af53fe287468fac47f617b927216ac.zip
arm64: uprobe: Return EOPNOTSUPP for AARCH32 instruction probing
commit d47422d953e258ad587b5edf2274eb95d08bdc7d upstream. As stated in linux/errno.h, ENOTSUPP should never be seen by user programs. When we set up uprobe with 32-bit perf and arm64 kernel, we would see the following vague error without useful hint. The sys_perf_event_open() syscall returned with 524 (INTERNAL ERROR: strerror_r(524, [buf], 128)=22) Use EOPNOTSUPP instead to indicate such cases. Signed-off-by: He Zhe <zhe.he@windriver.com> Link: https://lore.kernel.org/r/20210223082535.48730-1-zhe.he@windriver.com Cc: <stable@vger.kernel.org> Signed-off-by: Will Deacon <will@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch')
-rw-r--r--arch/arm64/kernel/probes/uprobes.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm64/kernel/probes/uprobes.c b/arch/arm64/kernel/probes/uprobes.c
index 636ca0119c0e..6aeb11aa7e28 100644
--- a/arch/arm64/kernel/probes/uprobes.c
+++ b/arch/arm64/kernel/probes/uprobes.c
@@ -41,7 +41,7 @@ int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm,
/* TODO: Currently we do not support AARCH32 instruction probing */
if (mm->context.flags & MMCF_AARCH32)
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
else if (!IS_ALIGNED(addr, AARCH64_INSN_SIZE))
return -EINVAL;