diff options
author | Ming Lei <ming.lei@redhat.com> | 2021-11-18 23:30:41 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2021-11-19 06:28:18 -0700 |
commit | 2b504bd4841bccbf3eb83c1fec229b65956ad8ad (patch) | |
tree | 378f430323f71a363397750bd26a821a080ef011 /block/bdev.c | |
parent | 15c30104965101b8e76b24d27035569d6613a7d6 (diff) | |
download | linux-stable-2b504bd4841bccbf3eb83c1fec229b65956ad8ad.tar.gz linux-stable-2b504bd4841bccbf3eb83c1fec229b65956ad8ad.tar.bz2 linux-stable-2b504bd4841bccbf3eb83c1fec229b65956ad8ad.zip |
blk-mq: don't insert FUA request with data into scheduler queue
We never insert flush request into scheduler queue before.
Recently commit d92ca9d8348f ("blk-mq: don't handle non-flush requests in
blk_insert_flush") tries to handle FUA data request as normal request.
This way has caused warning[1] in mq-deadline dd_exit_sched() or io hang in
case of kyber since RQF_ELVPRIV isn't set for flush request, then
->finish_request won't be called.
Fix the issue by inserting FUA data request with blk_mq_request_bypass_insert()
when the device supports FUA, just like what we did before.
[1] https://lore.kernel.org/linux-block/CAHj4cs-_vkTW=dAzbZYGxpEWSpzpcmaNeY1R=vH311+9vMUSdg@mail.gmail.com/
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Fixes: d92ca9d8348f ("blk-mq: don't handle non-flush requests in blk_insert_flush")
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20211118153041.2163228-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/bdev.c')
0 files changed, 0 insertions, 0 deletions