summaryrefslogtreecommitdiffstats
path: root/block/blk-pm.c
diff options
context:
space:
mode:
authorErick Archer <erick.archer@gmx.com>2024-01-20 14:54:00 +0100
committerPalmer Dabbelt <palmer@rivosinc.com>2024-03-20 08:56:07 -0700
commit28e4748e5e3d313056ed38abeff4b455abd02c1b (patch)
tree98571c4c496c626303359d2de00210638abfac8f /block/blk-pm.c
parent85ab6fdf3791c68aa7b8eb484f68855b8a6b9884 (diff)
downloadlinux-stable-28e4748e5e3d313056ed38abeff4b455abd02c1b.tar.gz
linux-stable-28e4748e5e3d313056ed38abeff4b455abd02c1b.tar.bz2
linux-stable-28e4748e5e3d313056ed38abeff4b455abd02c1b.zip
riscv: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, use the purpose specific kcalloc() function instead of the argument count * size in the kzalloc() function. Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter). Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1] Link: https://github.com/KSPP/linux/issues/162 Signed-off-by: Erick Archer <erick.archer@gmx.com> Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> Reviewed-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20240120135400.4710-1-erick.archer@gmx.com Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
Diffstat (limited to 'block/blk-pm.c')
0 files changed, 0 insertions, 0 deletions