diff options
author | Jeffle Xu <jefflexu@linux.alibaba.com> | 2020-12-02 19:11:45 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2020-12-02 12:43:02 -0700 |
commit | b0d97557ebfc9d5ba5f2939339a9fdd267abafeb (patch) | |
tree | a1a301e3d055b1388291774d8bf4ab43f3decbea /block/genhd.c | |
parent | 22b56c2964386ddced252be407150b22f85e209e (diff) | |
download | linux-stable-b0d97557ebfc9d5ba5f2939339a9fdd267abafeb.tar.gz linux-stable-b0d97557ebfc9d5ba5f2939339a9fdd267abafeb.tar.bz2 linux-stable-b0d97557ebfc9d5ba5f2939339a9fdd267abafeb.zip |
block: fix inflight statistics of part0
The inflight of partition 0 doesn't include inflight IOs to all
sub-partitions, since currently mq calculates inflight of specific
partition by simply camparing the value of the partition pointer.
Thus the following case is possible:
$ cat /sys/block/vda/inflight
0 0
$ cat /sys/block/vda/vda1/inflight
0 128
While single queue device (on a previous version, e.g. v3.10) has no
this issue:
$cat /sys/block/sda/sda3/inflight
0 33
$cat /sys/block/sda/inflight
0 33
Partition 0 should be specially handled since it represents the whole
disk. This issue is introduced since commit bf0ddaba65dd ("blk-mq: fix
sysfs inflight counter").
Besides, this patch can also fix the inflight statistics of part 0 in
/proc/diskstats. Before this patch, the inflight statistics of part 0
doesn't include that of sub partitions. (I have marked the 'inflight'
field with asterisk.)
$cat /proc/diskstats
259 0 nvme0n1 45974469 0 367814768 6445794 1 0 1 0 *0* 111062 6445794 0 0 0 0 0 0
259 2 nvme0n1p1 45974058 0 367797952 6445727 0 0 0 0 *33* 111001 6445727 0 0 0 0 0 0
This is introduced since commit f299b7c7a9de ("blk-mq: provide internal
in-flight variant").
Fixes: bf0ddaba65dd ("blk-mq: fix sysfs inflight counter")
Fixes: f299b7c7a9de ("blk-mq: provide internal in-flight variant")
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[axboe: adapt for 5.11 partition change]
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/genhd.c')
0 files changed, 0 insertions, 0 deletions