summaryrefslogtreecommitdiffstats
path: root/block/holder.c
diff options
context:
space:
mode:
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>2022-06-03 11:19:05 +0900
committerJens Axboe <axboe@kernel.dk>2022-06-02 23:02:37 -0600
commit41e46b3c2aa24f755b2ae9ec4ce931ba5f0d8532 (patch)
tree40575fecddd2d1e72ceae2f30a853665b0c75142 /block/holder.c
parent22b106e5355d6e7a9c3b5cb5ed4ef22ae585ea94 (diff)
downloadlinux-stable-41e46b3c2aa24f755b2ae9ec4ce931ba5f0d8532.tar.gz
linux-stable-41e46b3c2aa24f755b2ae9ec4ce931ba5f0d8532.tar.bz2
linux-stable-41e46b3c2aa24f755b2ae9ec4ce931ba5f0d8532.zip
block: Fix potential deadlock in blk_ia_range_sysfs_show()
When being read, a sysfs attribute is already protected against removal with the kobject node active reference counter. As a result, in blk_ia_range_sysfs_show(), there is no need to take the queue sysfs lock when reading the value of a range attribute. Using the queue sysfs lock in this function creates a potential deadlock situation with the disk removal, something that a lockdep signals with a splat when the device is removed: [ 760.703551] Possible unsafe locking scenario: [ 760.703551] [ 760.703554] CPU0 CPU1 [ 760.703556] ---- ---- [ 760.703558] lock(&q->sysfs_lock); [ 760.703565] lock(kn->active#385); [ 760.703573] lock(&q->sysfs_lock); [ 760.703579] lock(kn->active#385); [ 760.703587] [ 760.703587] *** DEADLOCK *** Solve this by removing the mutex_lock()/mutex_unlock() calls from blk_ia_range_sysfs_show(). Fixes: a2247f19ee1c ("block: Add independent access ranges support") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Link: https://lore.kernel.org/r/20220603021905.1441419-1-damien.lemoal@opensource.wdc.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/holder.c')
0 files changed, 0 insertions, 0 deletions