summaryrefslogtreecommitdiffstats
path: root/drivers/char/ipmi/ipmi_bt_sm.c
diff options
context:
space:
mode:
authorCorey Minyard <cminyard@mvista.com>2018-05-22 08:14:51 -0500
committerCorey Minyard <cminyard@mvista.com>2018-05-22 13:48:30 -0500
commitfe50a7d0393a552e4539da2d31261a59d6415950 (patch)
treee6fc65062c22a4056b540dd24cc017c7394fa04e /drivers/char/ipmi/ipmi_bt_sm.c
parent163475ebf9f3d1b516c1f8ee4f59eb8ff8e97ee8 (diff)
downloadlinux-stable-fe50a7d0393a552e4539da2d31261a59d6415950.tar.gz
linux-stable-fe50a7d0393a552e4539da2d31261a59d6415950.tar.bz2
linux-stable-fe50a7d0393a552e4539da2d31261a59d6415950.zip
ipmi:bt: Set the timeout before doing a capabilities check
There was one place where the timeout value for an operation was not being set, if a capabilities request was done from idle. Move the timeout value setting to before where that change might be requested. IMHO the cause here is the invisible returns in the macros. Maybe that's a job for later, though. Reported-by: Nordmark Claes <Claes.Nordmark@tieto.com> Signed-off-by: Corey Minyard <cminyard@mvista.com> Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/char/ipmi/ipmi_bt_sm.c')
-rw-r--r--drivers/char/ipmi/ipmi_bt_sm.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
index fd4ea8d87d4b..a3397664f800 100644
--- a/drivers/char/ipmi/ipmi_bt_sm.c
+++ b/drivers/char/ipmi/ipmi_bt_sm.c
@@ -504,11 +504,12 @@ static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
if (status & BT_H_BUSY) /* clear a leftover H_BUSY */
BT_CONTROL(BT_H_BUSY);
+ bt->timeout = bt->BT_CAP_req2rsp;
+
/* Read BT capabilities if it hasn't been done yet */
if (!bt->BT_CAP_outreqs)
BT_STATE_CHANGE(BT_STATE_CAPABILITIES_BEGIN,
SI_SM_CALL_WITHOUT_DELAY);
- bt->timeout = bt->BT_CAP_req2rsp;
BT_SI_SM_RETURN(SI_SM_IDLE);
case BT_STATE_XACTION_START: