diff options
author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-01-04 06:36:34 +0000 |
---|---|---|
committer | Stephen Boyd <sboyd@kernel.org> | 2018-03-12 15:12:26 -0700 |
commit | 9903e41ae1f5d50c93f268ca3304d4d7c64b9311 (patch) | |
tree | 16ac167d80f1884174dc0c4b748ef73f747b2982 /drivers/clk | |
parent | 56e1ee3539437a26ebec358167d1f8cd07253c3d (diff) | |
download | linux-stable-9903e41ae1f5d50c93f268ca3304d4d7c64b9311.tar.gz linux-stable-9903e41ae1f5d50c93f268ca3304d4d7c64b9311.tar.bz2 linux-stable-9903e41ae1f5d50c93f268ca3304d4d7c64b9311.zip |
clk: hisilicon: hi3660:Fix potential NULL dereference in hi3660_stub_clk_probe()
platform_get_resource() may return NULL, add proper check to
avoid potential NULL dereferencing.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2;
@@
res = platform_get_resource(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Fixes: 4f16f7ff3bc0 ("clk: hisilicon: Add support for Hi3660 stub clocks")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk')
-rw-r--r-- | drivers/clk/hisilicon/clk-hi3660-stub.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/clk/hisilicon/clk-hi3660-stub.c b/drivers/clk/hisilicon/clk-hi3660-stub.c index 9b6c72bbddf9..e8b2c43b1bb8 100644 --- a/drivers/clk/hisilicon/clk-hi3660-stub.c +++ b/drivers/clk/hisilicon/clk-hi3660-stub.c @@ -149,6 +149,8 @@ static int hi3660_stub_clk_probe(struct platform_device *pdev) return PTR_ERR(stub_clk_chan.mbox); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; freq_reg = devm_ioremap(dev, res->start, resource_size(res)); if (!freq_reg) return -ENOMEM; |