summaryrefslogtreecommitdiffstats
path: root/drivers/clocksource
diff options
context:
space:
mode:
authorBrian Norris <briannorris@chromium.org>2016-08-10 13:37:18 -0700
committerWolfram Sang <wsa@the-dreams.de>2016-08-15 00:55:14 +0200
commit4d01d88019261d05ec3bff5f1a6013393faa3b9e (patch)
tree69b17b0d974f38e5035a87a1649cd2db2a224db2 /drivers/clocksource
parentce8cb803d8b90458495f23606c706f0c0c857cdc (diff)
downloadlinux-stable-4d01d88019261d05ec3bff5f1a6013393faa3b9e.tar.gz
linux-stable-4d01d88019261d05ec3bff5f1a6013393faa3b9e.tar.bz2
linux-stable-4d01d88019261d05ec3bff5f1a6013393faa3b9e.zip
i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()
cros_ec_cmd_xfer returns success status if the command transport completes successfully, but the execution result is incorrectly ignored. In many cases, the execution result is assumed to be successful, leading to ignored errors and operating on uninitialized data. We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these problems. Let's use it. [Regarding the 'Fixes' tag; there is significant refactoring since the driver's introduction, but the underlying logical error exists throughout I believe] Fixes: 9d230c9e4f4e ("i2c: ChromeOS EC tunnel driver") Cc: <stable@vger.kernel.org> # 9798ac6d32c1 mfd: cros_ec: Add cros_ec_cmd_xfer_status() helper Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/clocksource')
0 files changed, 0 insertions, 0 deletions