diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-11-22 22:56:19 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2022-12-02 18:12:40 +0800 |
| commit | 3d780c8a9850ad60dee47a8d971ba7888f3d1bd3 (patch) | |
| tree | e195fc4ccadb91d96be2946ab66053c6f4128ced /drivers/crypto | |
| parent | 4d2b225a67e6df962bbeaad473bfd8f97cfbf478 (diff) | |
| download | linux-stable-3d780c8a9850ad60dee47a8d971ba7888f3d1bd3.tar.gz linux-stable-3d780c8a9850ad60dee47a8d971ba7888f3d1bd3.tar.bz2 linux-stable-3d780c8a9850ad60dee47a8d971ba7888f3d1bd3.zip | |
crypto: amlogic - Remove kcalloc without check
There is no real point in allocating dedicated memory for the irqs array.
MAXFLOW is only 2, so it is easier to allocated the needed space
directly within the 'meson_dev' structure.
This saves some memory allocation and avoids an indirection when using the
irqs array.
Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator...")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/amlogic/amlogic-gxl-core.c | 1 | ||||
| -rw-r--r-- | drivers/crypto/amlogic/amlogic-gxl.h | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index 6e7ae896717c..937187027ad5 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -237,7 +237,6 @@ static int meson_crypto_probe(struct platform_device *pdev) return err; } - mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL); for (i = 0; i < MAXFLOW; i++) { mc->irqs[i] = platform_get_irq(pdev, i); if (mc->irqs[i] < 0) diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h index dc0f142324a3..8c0746a1d6d4 100644 --- a/drivers/crypto/amlogic/amlogic-gxl.h +++ b/drivers/crypto/amlogic/amlogic-gxl.h @@ -95,7 +95,7 @@ struct meson_dev { struct device *dev; struct meson_flow *chanlist; atomic_t flow; - int *irqs; + int irqs[MAXFLOW]; #ifdef CONFIG_CRYPTO_DEV_AMLOGIC_GXL_DEBUG struct dentry *dbgfs_dir; #endif |