diff options
| author | Borislav Petkov <bp@suse.de> | 2022-03-08 14:16:17 +0100 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2022-04-11 11:43:26 +0200 |
| commit | 9fb9ce392aae0c6654efc42c80e2f6bab88d5fe3 (patch) | |
| tree | 936ad0f870760d221b85e65aadff185ab3312a32 /drivers/edac/edac_device_sysfs.c | |
| parent | fb8cd45ca39bdb216e358e36063d8b9962242107 (diff) | |
| download | linux-stable-9fb9ce392aae0c6654efc42c80e2f6bab88d5fe3.tar.gz linux-stable-9fb9ce392aae0c6654efc42c80e2f6bab88d5fe3.tar.bz2 linux-stable-9fb9ce392aae0c6654efc42c80e2f6bab88d5fe3.zip | |
EDAC/device: Get rid of the silly one-shot memory allocation in edac_device_alloc_ctl_info()
Use boring kzalloc() instead. Add pointers to the different allocated
members in struct edac_device_ctl_info for easier freeing later.
One of the reasons, perhaps, why it was done this way is to be able to
do a single kfree(ctl_info) without having to kfree() the other parts of
the struct too but that is not nearly a sensible reason as to why there
should be this obscure pointer alignment.
There should be no functional changes resulting from this.
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220310095254.1510-4-bp@alien8.de
Diffstat (limited to 'drivers/edac/edac_device_sysfs.c')
| -rw-r--r-- | drivers/edac/edac_device_sysfs.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c index 9a61d92bdf42..ac678b4a21fc 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -208,10 +208,7 @@ static void edac_device_ctrl_master_release(struct kobject *kobj) /* decrement the EDAC CORE module ref count */ module_put(edac_dev->owner); - /* free the control struct containing the 'main' kobj - * passed in to this routine - */ - kfree(edac_dev); + __edac_device_free_ctl_info(edac_dev); } /* ktype for the main (master) kobject */ |