summaryrefslogtreecommitdiffstats
path: root/drivers/edac/edac_mc_sysfs.c
diff options
context:
space:
mode:
authorAnna Karbownik <anna.karbownik@intel.com>2018-02-22 16:18:13 +0100
committerBorislav Petkov <bp@suse.de>2018-02-23 12:05:37 +0100
commitbf8486709ac7fad99e4040dea73fe466c57a4ae1 (patch)
treecdc8f8ef36be30e378cb8356d264179990209b04 /drivers/edac/edac_mc_sysfs.c
parent91ab883eb21325ad80f3473633f794c78ac87f51 (diff)
downloadlinux-stable-bf8486709ac7fad99e4040dea73fe466c57a4ae1.tar.gz
linux-stable-bf8486709ac7fad99e4040dea73fe466c57a4ae1.tar.bz2
linux-stable-bf8486709ac7fad99e4040dea73fe466c57a4ae1.zip
EDAC, sb_edac: Fix out of bound writes during DIMM configuration on KNL
Commit 3286d3eb906c ("EDAC, sb_edac: Drop NUM_CHANNELS from 8 back to 4") decreased NUM_CHANNELS from 8 to 4, but this is not enough for Knights Landing which supports up to 6 channels. This caused out-of-bounds writes to pvt->mirror_mode and pvt->tolm variables which don't pay critical role on KNL code path, so the memory corruption wasn't causing any visible driver failures. The easiest way of fixing it is to change NUM_CHANNELS to 6. Do that. An alternative solution would be to restructure the KNL part of the driver to 2MC/3channel representation. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Anna Karbownik <anna.karbownik@intel.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Tony Luck <tony.luck@intel.com> Cc: jim.m.snow@intel.com Cc: krzysztof.paliswiat@intel.com Cc: lukasz.odzioba@intel.com Cc: qiuxu.zhuo@intel.com Cc: linux-edac <linux-edac@vger.kernel.org> Cc: <stable@vger.kernel.org> Fixes: 3286d3eb906c ("EDAC, sb_edac: Drop NUM_CHANNELS from 8 back to 4") Link: http://lkml.kernel.org/r/1519312693-4789-1-git-send-email-anna.karbownik@intel.com [ Massage commit message. ] Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'drivers/edac/edac_mc_sysfs.c')
0 files changed, 0 insertions, 0 deletions