diff options
| author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2024-07-07 22:45:23 +0900 |
|---|---|---|
| committer | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2024-07-08 06:42:39 +0900 |
| commit | 9f349e8e532d7e50b57a3e10367a8eb64d89e104 (patch) | |
| tree | b2c2e201988241c62c81a98b233de6c0d679751d /drivers/firewire | |
| parent | 526e21a2aa6fa7ac3309a8c87f4d6e5f7e407cb6 (diff) | |
| download | linux-stable-9f349e8e532d7e50b57a3e10367a8eb64d89e104.tar.gz linux-stable-9f349e8e532d7e50b57a3e10367a8eb64d89e104.tar.bz2 linux-stable-9f349e8e532d7e50b57a3e10367a8eb64d89e104.zip | |
Revert "firewire: ohci: use common macro to interpret be32 data in le32 buffer"
This reverts commit f26a38e61c03fdfacb6b596e1daf665cf4526a60, since it
causes the following sparse warnings:
sparse warnings: (new ones prefixed by >>)
>> drivers/firewire/ohci.c:891:23: sparse: sparse: cast to restricted __be32
>> drivers/firewire/ohci.c:891:23: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:892:23: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:892:23: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:893:23: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:893:23: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:905:31: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:905:31: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:914:31: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:914:31: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:939:18: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:939:18: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:2033:23: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:2033:23: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:2037:27: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:2037:27: sparse: sparse: cast from restricted __le32
drivers/firewire/ohci.c:2038:27: sparse: sparse: cast to restricted __be32
drivers/firewire/ohci.c:2038:27: sparse: sparse: cast from restricted __le32
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407050656.03bw1YXA-lkp@intel.com/
Link: https://lore.kernel.org/r/20240707134523.11784-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Diffstat (limited to 'drivers/firewire')
| -rw-r--r-- | drivers/firewire/ohci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index f8d880574c19..314a29c0fd3e 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -879,7 +879,7 @@ static void ar_sync_buffers_for_cpu(struct ar_context *ctx, #if defined(CONFIG_PPC_PMAC) && defined(CONFIG_PPC32) static u32 cond_le32_to_cpu(__le32 value, bool has_be_header_quirk) { - return has_be_header_quirk ? be32_to_cpu(value) : le32_to_cpu(value); + return has_be_header_quirk ? (__force __u32)value : le32_to_cpu(value); } static bool has_be_header_quirk(const struct fw_ohci *ohci) |