diff options
author | Cristian Marussi <cristian.marussi@arm.com> | 2022-03-30 16:05:31 +0100 |
---|---|---|
committer | Sudeep Holla <sudeep.holla@arm.com> | 2022-04-28 10:47:19 +0100 |
commit | 4de1b36fae866c02f264f6bcda7a9a9e00ec5306 (patch) | |
tree | c53207fbfad90c723e4feac92e9ae62e274ce1a4 /drivers/firmware/arm_scmi/base.c | |
parent | bf36619a5463fbe6d3ecde37bb13680b532a253b (diff) | |
download | linux-stable-4de1b36fae866c02f264f6bcda7a9a9e00ec5306.tar.gz linux-stable-4de1b36fae866c02f264f6bcda7a9a9e00ec5306.tar.bz2 linux-stable-4de1b36fae866c02f264f6bcda7a9a9e00ec5306.zip |
firmware: arm_scmi: Make protocols initialisation fail on basic errors
Bail out of protocol initialisation routine early when basic information
about protocol version and attributes could not be retrieved. Failing to
act this way can lead to a successfully initialized SCMI protocol which
is in fact not fully functional.
Link: https://lore.kernel.org/r/20220330150551.2573938-3-cristian.marussi@arm.com
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/firmware/arm_scmi/base.c')
-rw-r--r-- | drivers/firmware/arm_scmi/base.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c index f5219334fd3a..ebaef5d320af 100644 --- a/drivers/firmware/arm_scmi/base.c +++ b/drivers/firmware/arm_scmi/base.c @@ -359,7 +359,10 @@ static int scmi_base_protocol_init(const struct scmi_protocol_handle *ph) rev->minor_ver = PROTOCOL_REV_MINOR(version); ph->set_priv(ph, rev); - scmi_base_attributes_get(ph); + ret = scmi_base_attributes_get(ph); + if (ret) + return ret; + scmi_base_vendor_id_get(ph, false); scmi_base_vendor_id_get(ph, true); scmi_base_implementation_version_get(ph); |