summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/bridge/parade-ps8640.c
diff options
context:
space:
mode:
authorChen-Yu Tsai <wenst@chromium.org>2022-07-21 17:22:58 +0800
committerRobert Foss <robert.foss@linaro.org>2022-07-21 14:50:36 +0200
commitfc94224c2e0ae8d83ac511a3ef4962178505469d (patch)
tree44d66b37e755628e1cdc5120d75121c6df929eb0 /drivers/gpu/drm/bridge/parade-ps8640.c
parent2b8428a10fd3763819eabf1acef6b5b2c7875520 (diff)
downloadlinux-stable-fc94224c2e0ae8d83ac511a3ef4962178505469d.tar.gz
linux-stable-fc94224c2e0ae8d83ac511a3ef4962178505469d.tar.bz2
linux-stable-fc94224c2e0ae8d83ac511a3ef4962178505469d.zip
drm/bridge: parade-ps8640: Fix regulator supply order
The datasheet says that VDD12 must be enabled and at full voltage before VDD33 is enabled. Reorder the bulk regulator supply names so that VDD12 is enabled before VDD33. Any enable ramp delays should be handled by setting proper constraints on the regulators. Fixes: bc1aee7fc8f0 ("drm/bridge: Add I2C based driver for ps8640 bridge") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Robert Foss <robert.foss@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220721092258.3397461-1-wenst@chromium.org
Diffstat (limited to 'drivers/gpu/drm/bridge/parade-ps8640.c')
-rw-r--r--drivers/gpu/drm/bridge/parade-ps8640.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index 31e88cb39f8a..49107a6cdac1 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -631,8 +631,8 @@ static int ps8640_probe(struct i2c_client *client)
if (!ps_bridge)
return -ENOMEM;
- ps_bridge->supplies[0].supply = "vdd33";
- ps_bridge->supplies[1].supply = "vdd12";
+ ps_bridge->supplies[0].supply = "vdd12";
+ ps_bridge->supplies[1].supply = "vdd33";
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ps_bridge->supplies),
ps_bridge->supplies);
if (ret)