summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/i915_perf.c
diff options
context:
space:
mode:
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>2018-03-26 10:08:22 +0100
committerLionel Landwerlin <lionel.g.landwerlin@intel.com>2018-03-29 13:30:02 +0100
commitb6dd47b9c82d619195370c38b7579fe18a8f6055 (patch)
tree15ebeb510f4c63f6c87175862d6598a370e7c0c6 /drivers/gpu/drm/i915/i915_perf.c
parent1de401c08fa805f3ac34604af1d43f48aeb17eb4 (diff)
downloadlinux-stable-b6dd47b9c82d619195370c38b7579fe18a8f6055.tar.gz
linux-stable-b6dd47b9c82d619195370c38b7579fe18a8f6055.tar.bz2
linux-stable-b6dd47b9c82d619195370c38b7579fe18a8f6055.zip
drm/i915/perf: check the value of PROP_SAMPLE_OA uapi parameter
We've been a bit loose about this opening parameter. We should only add the flag for writing OA reports when the value of this parameter is != 0. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Matthew Auld <matthew.auld@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180326090831.22686-3-lionel.g.landwerlin@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/i915_perf.c')
-rw-r--r--drivers/gpu/drm/i915/i915_perf.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 30444bb3aaa1..21a985bd4413 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -2746,7 +2746,8 @@ static int read_properties_unlocked(struct drm_i915_private *dev_priv,
props->ctx_handle = value;
break;
case DRM_I915_PERF_PROP_SAMPLE_OA:
- props->sample_flags |= SAMPLE_OA_REPORT;
+ if (value)
+ props->sample_flags |= SAMPLE_OA_REPORT;
break;
case DRM_I915_PERF_PROP_OA_METRICS_SET:
if (value == 0) {