diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2019-01-13 09:47:43 +0100 |
---|---|---|
committer | Heiko Stuebner <heiko@sntech.de> | 2019-01-13 19:20:45 +0100 |
commit | a17ce9960b3628b9f546c454741a1cad551d5695 (patch) | |
tree | c4641390c2ede15a0fecd8487f80c9e15d64b0f3 /drivers/gpu/drm/rockchip | |
parent | 4089e272ac61603931beb024d4d640de2cb390e0 (diff) | |
download | linux-stable-a17ce9960b3628b9f546c454741a1cad551d5695.tar.gz linux-stable-a17ce9960b3628b9f546c454741a1cad551d5695.tar.bz2 linux-stable-a17ce9960b3628b9f546c454741a1cad551d5695.zip |
drm/rockchip: add missing of_node_put
The device node iterators perform an of_node_get on each iteration, so a
jump out of the loop requires an of_node_put.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
+ of_node_put(child);
? break;
...
}
... when != child
// </smpl>
Fixes: 1f0f01515172 ("drm/rockchip: Add support for Rockchip Soc RGB output interface")
Cc: stable@vger.kernel.org
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[added fixes and cc-stable]
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr
Diffstat (limited to 'drivers/gpu/drm/rockchip')
-rw-r--r-- | drivers/gpu/drm/rockchip/rockchip_rgb.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 96ac1458a59c..37f93022a106 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -113,8 +113,10 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, child_count++; ret = drm_of_find_panel_or_bridge(dev->of_node, 0, endpoint_id, &panel, &bridge); - if (!ret) + if (!ret) { + of_node_put(endpoint); break; + } } of_node_put(port); |