diff options
author | Stephen Boyd <swboyd@chromium.org> | 2019-07-30 11:15:16 -0700 |
---|---|---|
committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2019-07-30 22:40:03 +0200 |
commit | c1030cd456198a2c58f718c3c4b215698d635553 (patch) | |
tree | 466393b068eac0bcbefcd5584061e0e8d84a32c8 /drivers/hsi/controllers/omap_ssi_core.c | |
parent | e008227eb34fe14eb5fdb1ca2a07ac018dd9f22a (diff) | |
download | linux-stable-c1030cd456198a2c58f718c3c4b215698d635553.tar.gz linux-stable-c1030cd456198a2c58f718c3c4b215698d635553.tar.bz2 linux-stable-c1030cd456198a2c58f718c3c4b215698d635553.zip |
HSI: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/hsi/controllers/omap_ssi_core.c')
-rw-r--r-- | drivers/hsi/controllers/omap_ssi_core.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c index 0cba567ee2d7..4bc4a201f0f6 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -370,10 +370,8 @@ static int ssi_add_controller(struct hsi_controller *ssi, if (err < 0) goto out_err; err = platform_get_irq_byname(pd, "gdd_mpu"); - if (err < 0) { - dev_err(&pd->dev, "GDD IRQ resource missing\n"); + if (err < 0) goto out_err; - } omap_ssi->gdd_irq = err; tasklet_init(&omap_ssi->gdd_tasklet, ssi_gdd_tasklet, (unsigned long)ssi); |