diff options
| author | Matthias Kaehlcke <mka@chromium.org> | 2018-08-27 14:14:53 -0700 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2018-09-02 18:52:04 +0100 |
| commit | 1e46774fec4b54adbd7cc15f1931e9df98664530 (patch) | |
| tree | da285d24b61eeb631ae9aa96557f0e5def4a0757 /drivers/iio/adc/qcom-spmi-adc5.c | |
| parent | 21eab7861688aa4c69fcb88440cc0c4a422bdcd6 (diff) | |
| download | linux-stable-1e46774fec4b54adbd7cc15f1931e9df98664530.tar.gz linux-stable-1e46774fec4b54adbd7cc15f1931e9df98664530.tar.bz2 linux-stable-1e46774fec4b54adbd7cc15f1931e9df98664530.zip | |
iio: adc: qcom-spmi-adc5: Verify channel numbers from DT
The driver only defines a subset of all possible ADC channels. Channel
numbers read from the device tree are accepted as long as they don't
exceed a max value, even when no channel definition exists. Add a
check to abort initialization in this case.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/adc/qcom-spmi-adc5.c')
| -rw-r--r-- | drivers/iio/adc/qcom-spmi-adc5.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c index 1f9298a5c83d..f9af6b082916 100644 --- a/drivers/iio/adc/qcom-spmi-adc5.c +++ b/drivers/iio/adc/qcom-spmi-adc5.c @@ -519,7 +519,8 @@ static int adc5_get_dt_channel_data(struct adc5_chip *adc, return ret; } - if (chan > ADC5_PARALLEL_ISENSE_VBAT_IDATA) { + if (chan > ADC5_PARALLEL_ISENSE_VBAT_IDATA || + !data->adc_chans[chan].datasheet_name) { dev_err(dev, "%s invalid channel number %d\n", name, chan); return -EINVAL; } |