diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-04-30 10:16:03 +0200 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2022-06-11 14:35:25 +0100 |
| commit | 8d3d6baa4990c0d90672d3e97d2b3473feac8136 (patch) | |
| tree | a169f6d8fb14241ca296d692509fa0e20a641238 /drivers/iio | |
| parent | 5004e24a466ca32bf0d218bd7adb96cb2ef30450 (diff) | |
| download | linux-stable-8d3d6baa4990c0d90672d3e97d2b3473feac8136.tar.gz linux-stable-8d3d6baa4990c0d90672d3e97d2b3473feac8136.tar.bz2 linux-stable-8d3d6baa4990c0d90672d3e97d2b3473feac8136.zip | |
iio:light:isl29028: Remove duplicated error reporting in .remove()
Returning an error value in an i2c remove callback results in an error
message being emitted by the i2c core, but otherwise it doesn't make a
difference. The device goes away anyhow and the devm cleanups are
called.
As isl29028_clear_configure_ret() already emits an error message on
failure and the additional error message by the i2c core doesn't add any
useful information, change the return value to zero to suppress this
message.
This patch is a preparation for making i2c remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220430081607.15078-6-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
| -rw-r--r-- | drivers/iio/light/isl29028.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c index 9de3262aa688..720fa83d44e0 100644 --- a/drivers/iio/light/isl29028.c +++ b/drivers/iio/light/isl29028.c @@ -646,7 +646,9 @@ static int isl29028_remove(struct i2c_client *client) pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); - return isl29028_clear_configure_reg(chip); + isl29028_clear_configure_reg(chip); + + return 0; } static int __maybe_unused isl29028_suspend(struct device *dev) |