diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-08-15 12:58:46 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-27 14:51:09 +0100 |
| commit | e706ece1148f8ba3457578ad1d3a5ed65f4688b0 (patch) | |
| tree | e3483ba379d3cf495e6b68071ef97cddc6312902 /drivers/iio | |
| parent | e7728e18a728bcbd072bca82650b10e0ba55a238 (diff) | |
| download | linux-stable-e706ece1148f8ba3457578ad1d3a5ed65f4688b0.tar.gz linux-stable-e706ece1148f8ba3457578ad1d3a5ed65f4688b0.tar.bz2 linux-stable-e706ece1148f8ba3457578ad1d3a5ed65f4688b0.zip | |
iio: dac: ad5380: fix incorrect assignment to val
[ Upstream commit b1e18768ef1214c0a8048327918a182cabe09f9d ]
Currently the pointer val is being incorrectly incremented
instead of the value pointed to by val. Fix this by adding
in the missing * indirection operator.
Addresses-Coverity: ("Unused value")
Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/iio')
| -rw-r--r-- | drivers/iio/dac/ad5380.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c index 873c2bf637c0..617c9f7fe59a 100644 --- a/drivers/iio/dac/ad5380.c +++ b/drivers/iio/dac/ad5380.c @@ -221,7 +221,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev, if (ret) return ret; *val >>= chan->scan_type.shift; - val -= (1 << chan->scan_type.realbits) / 2; + *val -= (1 << chan->scan_type.realbits) / 2; return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: *val = 2 * st->vref; |