diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2020-12-27 18:11:24 +0100 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2021-01-09 21:52:45 +0000 |
| commit | ed0ccf6d22cc9fd7e3a2ba66238c68bb10992721 (patch) | |
| tree | 2ed0f7a077ddb50b9daa0e1df37890b61af2b719 /drivers/iio | |
| parent | b9968e16adacb9289ab5d4659e0d3201388a12db (diff) | |
| download | linux-stable-ed0ccf6d22cc9fd7e3a2ba66238c68bb10992721.tar.gz linux-stable-ed0ccf6d22cc9fd7e3a2ba66238c68bb10992721.tar.bz2 linux-stable-ed0ccf6d22cc9fd7e3a2ba66238c68bb10992721.zip | |
iio: vl6180: Use DIV_ROUND_CLOSEST() instead of open-coding it
Use DIV_ROUND_CLOSEST() instead of open-coding it. This documents intent
and makes it more clear what is going on for the casual reviewer.
Generated using the following the Coccinelle semantic patch.
// <smpl>
@r1@
expression x;
constant C1;
constant C2;
@@
((x) + C1) / C2
@script:python@
C1 << r1.C1;
C2 << r1.C2;
@@
try:
if int(C1) * 2 != int(C2):
cocci.include_match(False)
except:
cocci.include_match(False)
@@
expression r1.x;
constant r1.C1;
constant r1.C2;
@@
-(((x) + C1) / C2)
+DIV_ROUND_CLOSEST(x, C2)
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://lore.kernel.org/r/20201227171126.28216-1-lars@metafoo.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
| -rw-r--r-- | drivers/iio/light/vl6180.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/light/vl6180.c b/drivers/iio/light/vl6180.c index 4775bd785e50..d47a4f6f4e87 100644 --- a/drivers/iio/light/vl6180.c +++ b/drivers/iio/light/vl6180.c @@ -392,7 +392,7 @@ static int vl6180_set_it(struct vl6180_data *data, int val, int val2) { int ret, it_ms; - it_ms = (val2 + 500) / 1000; /* round to ms */ + it_ms = DIV_ROUND_CLOSEST(val2, 1000); /* round to ms */ if (val != 0 || it_ms < 1 || it_ms > 512) return -EINVAL; |