summaryrefslogtreecommitdiffstats
path: root/drivers/iio
diff options
context:
space:
mode:
authorVasileios Amoiridis <vassilisamir@gmail.com>2024-10-31 00:54:24 +0100
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2024-11-01 14:54:48 +0000
commitf928099e5f5c3ce60ecbd70ea17614e9b253068f (patch)
tree00b84bd148176bc80b2db7b8053ad42f1dbbf32b /drivers/iio
parent869aa5e847696bcda8966be9d03de2560226bcc3 (diff)
downloadlinux-stable-f928099e5f5c3ce60ecbd70ea17614e9b253068f.tar.gz
linux-stable-f928099e5f5c3ce60ecbd70ea17614e9b253068f.tar.bz2
linux-stable-f928099e5f5c3ce60ecbd70ea17614e9b253068f.zip
iio: chemical: bme680: use s16 variable for temp value to avoid casting
Use local s16 variable for the temperature channel to avoid casting it later before passing it to the bme680_read_temp() function. This way, possible endianness and initialization issues are avoided. Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> Link: https://patch.msgid.link/20241030235424.214935-2-vassilisamir@gmail.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
-rw-r--r--drivers/iio/chemical/bme680_core.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
index 871921d81e70..6d11f9188367 100644
--- a/drivers/iio/chemical/bme680_core.c
+++ b/drivers/iio/chemical/bme680_core.c
@@ -741,6 +741,7 @@ static int bme680_read_raw(struct iio_dev *indio_dev,
{
struct bme680_data *data = iio_priv(indio_dev);
int chan_val, ret;
+ s16 temp_chan_val;
guard(mutex)(&data->lock);
@@ -757,11 +758,11 @@ static int bme680_read_raw(struct iio_dev *indio_dev,
case IIO_CHAN_INFO_PROCESSED:
switch (chan->type) {
case IIO_TEMP:
- ret = bme680_read_temp(data, (s16 *)&chan_val);
+ ret = bme680_read_temp(data, &temp_chan_val);
if (ret)
return ret;
- *val = chan_val * 10;
+ *val = temp_chan_val * 10;
return IIO_VAL_INT;
case IIO_PRESSURE:
ret = bme680_read_press(data, &chan_val);