summaryrefslogtreecommitdiffstats
path: root/drivers/infiniband
diff options
context:
space:
mode:
authorLeon Romanovsky <leonro@nvidia.com>2023-06-13 11:15:57 +0300
committerJason Gunthorpe <jgg@nvidia.com>2023-06-21 14:08:28 -0300
commit147394dbe1237ef1f2da528c238633215f7193e1 (patch)
treeb8fe3f9242ee2cee94049227942e6e32db9f5d0c /drivers/infiniband
parent6735041fd8460a94ae367830ece8ef65f191227a (diff)
downloadlinux-stable-147394dbe1237ef1f2da528c238633215f7193e1.tar.gz
linux-stable-147394dbe1237ef1f2da528c238633215f7193e1.tar.bz2
linux-stable-147394dbe1237ef1f2da528c238633215f7193e1.zip
RDMA/bnxt_re: Initialize opcode while sending message
Fix compilation warning: drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:325:18: error: variable 'opcode' is uninitialized when used here [-Werror,-Wuninitialized] crsqe->opcode = opcode; ^~~~~~ drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:291:11: note: initialize the variable 'opcode' to silence this warning u8 opcode; ^ = '\0' Fixes: bcfee4ce3e01 ("RDMA/bnxt_re: remove redundant cmdq_bitmap") Link: https://lore.kernel.org/r/6ad1e44be2b560986da6fdc6b68da606413e9026.1686644105.git.leonro@nvidia.com Acked-by: Selvin Xavier <selvin.xavier@broadcom.com> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r--drivers/infiniband/hw/bnxt_re/qplib_rcfw.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
index bb5aebafe162..92b3a4fbd0b2 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
@@ -274,7 +274,7 @@ static void __send_message_no_waiter(struct bnxt_qplib_rcfw *rcfw,
}
static int __send_message(struct bnxt_qplib_rcfw *rcfw,
- struct bnxt_qplib_cmdqmsg *msg)
+ struct bnxt_qplib_cmdqmsg *msg, u8 opcode)
{
u32 bsize, free_slots, required_slots;
struct bnxt_qplib_cmdq_ctx *cmdq;
@@ -285,7 +285,6 @@ static int __send_message(struct bnxt_qplib_rcfw *rcfw,
struct pci_dev *pdev;
unsigned long flags;
u16 cookie;
- u8 opcode;
u8 *preq;
cmdq = &rcfw->cmdq;
@@ -490,7 +489,7 @@ static int __bnxt_qplib_rcfw_send_message(struct bnxt_qplib_rcfw *rcfw,
if (rc)
return rc == -ENXIO ? bnxt_qplib_map_rc(opcode) : rc;
- rc = __send_message(rcfw, msg);
+ rc = __send_message(rcfw, msg, opcode);
if (rc)
return rc;