diff options
author | Michael Ellerman <mpe@ellerman.id.au> | 2020-12-14 21:56:16 +1100 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2020-12-15 13:13:49 +1100 |
commit | 1791ebd131c46539b024c0f2ebf12b6c88a265b9 (patch) | |
tree | 7523a9633ccb002cf57942844d7810aa569baf6d /drivers/iommu/mtk_iommu.h | |
parent | 44b4c4450f8d31296ba633d74be753a85fd627bd (diff) | |
download | linux-stable-1791ebd131c46539b024c0f2ebf12b6c88a265b9.tar.gz linux-stable-1791ebd131c46539b024c0f2ebf12b6c88a265b9.tar.bz2 linux-stable-1791ebd131c46539b024c0f2ebf12b6c88a265b9.zip |
powerpc: Inline setup_kup()
setup_kup() is used by both 64-bit and 32-bit code. However on 64-bit
it must not be __init, because it's used for CPU hotplug, whereas on
32-bit it should be __init because it calls setup_kuap/kuep() which
are __init.
We worked around that problem in the past by marking it __ref, see
commit 67d53f30e23e ("powerpc/mm: fix section mismatch for
setup_kup()").
Marking it __ref basically just omits it from section mismatch
checking, which can lead to bugs, and in fact it did, see commit
44b4c4450f8d ("powerpc/64s: Mark the kuap/kuep functions non __init")
We can avoid all these problems by just making it static inline.
Because all it does is call other functions, making it inline actually
shrinks the 32-bit vmlinux by ~76 bytes.
Make it __always_inline as pointed out by Christophe.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201214123011.311024-1-mpe@ellerman.id.au
Diffstat (limited to 'drivers/iommu/mtk_iommu.h')
0 files changed, 0 insertions, 0 deletions