diff options
author | Arnd Bergmann <arnd@arndb.de> | 2010-06-02 14:28:52 +0200 |
---|---|---|
committer | Arnd Bergmann <arnd@arndb.de> | 2010-09-15 21:00:46 +0200 |
commit | 5aa82940b23d0c6e4083d48e387a16b8ad530a47 (patch) | |
tree | ea6fe6dd8a545e104aa5a139d048123a522897a7 /drivers/macintosh/via-pmu.c | |
parent | c45d15d24eb2b49bf734e1e5e7e103befb76b19b (diff) | |
download | linux-stable-5aa82940b23d0c6e4083d48e387a16b8ad530a47.tar.gz linux-stable-5aa82940b23d0c6e4083d48e387a16b8ad530a47.tar.bz2 linux-stable-5aa82940b23d0c6e4083d48e387a16b8ad530a47.zip |
mtd: autoconvert trivial BKL users to private mutex
All these files use the big kernel lock in a trivial
way to serialize their private file operations,
typically resulting from an earlier semi-automatic
pushdown from VFS.
None of these drivers appears to want to lock against
other code, and they all use the BKL as the top-level
lock in their file operations, meaning that there
is no lock-order inversion problem.
Consequently, we can remove the BKL completely,
replacing it with a per-file mutex in every case.
Using a scripted approach means we can avoid
typos.
file=$1
name=$2
if grep -q lock_kernel ${file} ; then
if grep -q 'include.*linux.mutex.h' ${file} ; then
sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
else
sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
fi
sed -i ${file} \
-e "/^#include.*linux.mutex.h/,$ {
1,/^\(static\|int\|long\)/ {
/^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);
} }" \
-e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
-e '/[ ]*cycle_kernel_lock();/d'
else
sed -i -e '/include.*\<smp_lock.h\>/d' ${file} \
-e '/cycle_kernel_lock()/d'
fi
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: David Woodhouse <David.Woodhouse@intel.com>
Cc: linux-mtd@lists.infradead.org
Diffstat (limited to 'drivers/macintosh/via-pmu.c')
0 files changed, 0 insertions, 0 deletions