summaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorGeert Uytterhoeven <geert+renesas@glider.be>2022-05-18 11:04:19 +0200
committerDavid S. Miller <davem@davemloft.net>2022-05-18 14:13:09 +0100
commita3641ca416a3da7cbeae5bcf1fc26ba9797a1438 (patch)
treec8179354c870cb1c13917ee899d114cd2572e85a /drivers/md
parent223153ea6c79a0d78dc2a04e3300de1deb336f14 (diff)
downloadlinux-stable-a3641ca416a3da7cbeae5bcf1fc26ba9797a1438.tar.gz
linux-stable-a3641ca416a3da7cbeae5bcf1fc26ba9797a1438.tar.bz2
linux-stable-a3641ca416a3da7cbeae5bcf1fc26ba9797a1438.zip
net: smc911x: Fix min() use in debug code
If ENABLE_SMC_DEBUG_PKTS=1: drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_hardware_send_pkt’: include/linux/minmax.h:20:28: error: comparison of distinct pointer types lacks a cast [-Werror] 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ drivers/net/ethernet/smsc/smc911x.c:483:17: note: in expansion of macro ‘min’ 483 | PRINT_PKT(buf, min(len, 64)); Fix this by making the constant unsigned, to match the type of "len". While at it, replace the other missed ternary operator by min(), too. Convert the dummy PRINT_PKT() from a macro to a static inline function, to catch mistakes like this without having to enable debug options manually. Fixes: 5ff0348b7f755aac ("net: smc911x: replace ternary operator with min()") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/md')
0 files changed, 0 insertions, 0 deletions