summaryrefslogtreecommitdiffstats
path: root/drivers/media/platform/mtk-mdp
diff options
context:
space:
mode:
authorNishka Dasgupta <nishkadg.linux@gmail.com>2019-07-09 14:24:54 -0300
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-08-13 11:49:46 -0300
commit22ff7d4ca3f748e3b685fd2385afda18b9fa0258 (patch)
tree98d4fde3ca5cf5ac78395337dbb68f56fc5772c5 /drivers/media/platform/mtk-mdp
parent4fd22938569c14f6092c05880ca387409d78355f (diff)
downloadlinux-stable-22ff7d4ca3f748e3b685fd2385afda18b9fa0258.tar.gz
linux-stable-22ff7d4ca3f748e3b685fd2385afda18b9fa0258.tar.bz2
linux-stable-22ff7d4ca3f748e3b685fd2385afda18b9fa0258.zip
media: platform: mtk-mdp: mtk_mdp_core: Add of_node_put() before goto
Each iteration of for_each_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the goto in two places. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Acked-by: Houlong Wei <houlong.wei@mediatek.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/platform/mtk-mdp')
-rw-r--r--drivers/media/platform/mtk-mdp/mtk_mdp_core.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
index 5d44f2e92dd5..c1e29a46ae69 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
@@ -147,13 +147,16 @@ static int mtk_mdp_probe(struct platform_device *pdev)
comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL);
if (!comp) {
ret = -ENOMEM;
+ of_node_put(node);
goto err_comp;
}
mdp->comp[comp_id] = comp;
ret = mtk_mdp_comp_init(dev, node, comp, comp_id);
- if (ret)
+ if (ret) {
+ of_node_put(node);
goto err_comp;
+ }
}
mdp->job_wq = create_singlethread_workqueue(MTK_MDP_MODULE_NAME);