diff options
author | Tuo Li <islituo@gmail.com> | 2021-08-05 09:55:35 +0200 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-09-30 10:07:54 +0200 |
commit | 8515965e5e33f4feb56134348c95953f3eadfb26 (patch) | |
tree | 9312eb2fb588f0d5ea5cb3801049bb436e758fcd /drivers/media/platform | |
parent | ea8a5c118e2491726ffd27fd3fc149110d104095 (diff) | |
download | linux-stable-8515965e5e33f4feb56134348c95953f3eadfb26.tar.gz linux-stable-8515965e5e33f4feb56134348c95953f3eadfb26.tar.bz2 linux-stable-8515965e5e33f4feb56134348c95953f3eadfb26.zip |
media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe()
The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is
checked in:
if (!dev->plat_dev)
This indicates both dev->plat_dev and pdev can be NULL. If so, the
function dev_err() is called to print error information.
dev_err(&pdev->dev, "No platform data specified\n");
However, &pdev->dev is an illegal address, and it is dereferenced in
dev_err().
To fix this possible null-pointer dereference, replace dev_err() with
mfc_err().
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Tuo Li <islituo@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/platform')
-rw-r--r-- | drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index e0ec24b39fd4..293af8e664f4 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1283,7 +1283,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) spin_lock_init(&dev->condlock); dev->plat_dev = pdev; if (!dev->plat_dev) { - dev_err(&pdev->dev, "No platform data specified\n"); + mfc_err("No platform data specified\n"); return -ENODEV; } |