diff options
| author | Colin Ian King <colin.king@canonical.com> | 2021-02-25 16:43:27 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-03-11 11:59:44 +0100 |
| commit | 5cde22fcc7271812a7944c47b40100df15908358 (patch) | |
| tree | ee1dc5c2ff96858b3a0b81a9780c51d509f9ac51 /drivers/media/test-drivers/vivid | |
| parent | 29a42595c8dc4235630d39c8b8e88ed3c594c23f (diff) | |
| download | linux-stable-5cde22fcc7271812a7944c47b40100df15908358.tar.gz linux-stable-5cde22fcc7271812a7944c47b40100df15908358.tar.bz2 linux-stable-5cde22fcc7271812a7944c47b40100df15908358.zip | |
media: vivid: fix assignment of dev->fbuf_out_flags
Currently the chroma_flags and alpha_flags are being zero'd with a bit-wise
mask and the following statement should be bit-wise or'ing in the new flag
bits but instead is making a direct assignment. Fix this by using the |=
operator rather than an assignment.
Addresses-Coverity: ("Unused value")
Fixes: ef834f7836ec ("[media] vivid: add the video capture and output parts")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/test-drivers/vivid')
| -rw-r--r-- | drivers/media/test-drivers/vivid/vivid-vid-out.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/test-drivers/vivid/vivid-vid-out.c b/drivers/media/test-drivers/vivid/vivid-vid-out.c index ac1e981e8342..9f731f085179 100644 --- a/drivers/media/test-drivers/vivid/vivid-vid-out.c +++ b/drivers/media/test-drivers/vivid/vivid-vid-out.c @@ -1021,7 +1021,7 @@ int vivid_vid_out_s_fbuf(struct file *file, void *fh, return -EINVAL; } dev->fbuf_out_flags &= ~(chroma_flags | alpha_flags); - dev->fbuf_out_flags = a->flags & (chroma_flags | alpha_flags); + dev->fbuf_out_flags |= a->flags & (chroma_flags | alpha_flags); return 0; } |