diff options
| author | Chen Jiahao <chenjiahao16@huawei.com> | 2023-08-16 10:23:23 +0800 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2023-09-27 09:39:55 +0200 |
| commit | 16fae979ed6b2753c07bdc9943cd9892349b69d4 (patch) | |
| tree | 60bd240ba9c6e5514339c35d2e99a1551c99b969 /drivers/media/usb/siano | |
| parent | e2f01278781f80ccb329218793d78980cdd8d3c3 (diff) | |
| download | linux-stable-16fae979ed6b2753c07bdc9943cd9892349b69d4.tar.gz linux-stable-16fae979ed6b2753c07bdc9943cd9892349b69d4.tar.bz2 linux-stable-16fae979ed6b2753c07bdc9943cd9892349b69d4.zip | |
media: usb: siano: Use kmemdup to simplify kmalloc and memcpy logic
Using kmemdup() helper function rather than implementing it again
with kmalloc() + memcpy(), which improves the code readability.
Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/media/usb/siano')
| -rw-r--r-- | drivers/media/usb/siano/smsusb.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c index 8a39cac76c58..9d9e14c858e6 100644 --- a/drivers/media/usb/siano/smsusb.c +++ b/drivers/media/usb/siano/smsusb.c @@ -279,10 +279,8 @@ static int smsusb1_load_firmware(struct usb_device *udev, int id, int board_id) } } - fw_buffer = kmalloc(fw->size, GFP_KERNEL); + fw_buffer = kmemdup(fw->data, fw->size, GFP_KERNEL); if (fw_buffer) { - memcpy(fw_buffer, fw->data, fw->size); - rc = usb_bulk_msg(udev, usb_sndbulkpipe(udev, 2), fw_buffer, fw->size, &dummy, 1000); |