summaryrefslogtreecommitdiffstats
path: root/drivers/media/usb
diff options
context:
space:
mode:
authorGhanshyam Agrawal <ghanshyam1898@gmail.com>2023-11-25 14:32:36 +0530
committerHans Verkuil <hverkuil-cisco@xs4all.nl>2023-12-07 08:31:15 +0100
commitb3695e86d25aafbe175dd51f6aaf6f68d341d590 (patch)
tree69642fcfd1e81ef33f662ada2d84e1108f1a54b9 /drivers/media/usb
parent5d3c8990e2bbf929cb211563dadd70708f42e4e6 (diff)
downloadlinux-stable-b3695e86d25aafbe175dd51f6aaf6f68d341d590.tar.gz
linux-stable-b3695e86d25aafbe175dd51f6aaf6f68d341d590.tar.bz2
linux-stable-b3695e86d25aafbe175dd51f6aaf6f68d341d590.zip
media: stk1160: Fixed high volume of stk1160_dbg messages
The function stk1160_dbg gets called too many times, which causes the output to get flooded with messages. Since stk1160_dbg uses printk, it is now replaced with printk_ratelimited. Suggested-by: Phillip Potter <phil@philpotter.co.uk> Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/media/usb')
-rw-r--r--drivers/media/usb/stk1160/stk1160-video.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c
index 4e966f6bf608..366f0e4a5dc0 100644
--- a/drivers/media/usb/stk1160/stk1160-video.c
+++ b/drivers/media/usb/stk1160/stk1160-video.c
@@ -107,8 +107,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
/*
* TODO: These stk1160_dbg are very spammy!
- * We should 1) check why we are getting them
- * and 2) add ratelimit.
+ * We should check why we are getting them.
*
* UPDATE: One of the reasons (the only one?) for getting these
* is incorrect standard (mismatch between expected and configured).
@@ -151,7 +150,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
/* Let the bug hunt begin! sanity checks! */
if (lencopy < 0) {
- stk1160_dbg("copy skipped: negative lencopy\n");
+ printk_ratelimited(KERN_DEBUG "copy skipped: negative lencopy\n");
return;
}