diff options
author | Linus Walleij <linus.walleij@linaro.org> | 2016-09-20 11:34:38 +0200 |
---|---|---|
committer | Ulf Hansson <ulf.hansson@linaro.org> | 2016-09-26 21:31:31 +0200 |
commit | 29eb7bd01e80df316ab9d1da1a4ee580fae89188 (patch) | |
tree | e665ba24917d0e009babbd5fe03fa25066f79513 /drivers/mmc/card/queue.h | |
parent | c80f275fa1766cfdbc24c7a5d3d870df1fe730db (diff) | |
download | linux-stable-29eb7bd01e80df316ab9d1da1a4ee580fae89188.tar.gz linux-stable-29eb7bd01e80df316ab9d1da1a4ee580fae89188.tar.bz2 linux-stable-29eb7bd01e80df316ab9d1da1a4ee580fae89188.zip |
mmc: card: do away with indirection pointer
We have enough vtables in the kernel as it is, we don't need
this one to create even more artificial separation of concerns.
As is proved by the Makefile:
obj-$(CONFIG_MMC_BLOCK) += mmc_block.o
mmc_block-objs := block.o queue.o
block.c and queue.c are baked into the same mmc_block.o object.
So why would one of these objects access a function in the
other object by dereferencing a pointer?
Create a new block.h header file for the single shared function
from block to queue and remove the function pointer and just
call the queue request function.
Apart from making the code more readable, this also makes link
optimizations possible and probably speeds up the call as well.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc/card/queue.h')
-rw-r--r-- | drivers/mmc/card/queue.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/mmc/card/queue.h b/drivers/mmc/card/queue.h index fee5e1271465..3c15a75bae86 100644 --- a/drivers/mmc/card/queue.h +++ b/drivers/mmc/card/queue.h @@ -57,8 +57,6 @@ struct mmc_queue { unsigned int flags; #define MMC_QUEUE_SUSPENDED (1 << 0) #define MMC_QUEUE_NEW_REQUEST (1 << 1) - - int (*issue_fn)(struct mmc_queue *, struct request *); void *data; struct request_queue *queue; struct mmc_queue_req mqrq[2]; |