summaryrefslogtreecommitdiffstats
path: root/drivers/mmc/core
diff options
context:
space:
mode:
authorMatthew Ma <mahongwei@zeku.com>2022-10-14 11:49:51 +0800
committerUlf Hansson <ulf.hansson@linaro.org>2022-10-17 11:51:34 +0200
commit9972e6b404884adae9eec7463e30d9b3c9a70b18 (patch)
tree6253fed96b23b2461ce787e44051de217b049249 /drivers/mmc/core
parent9dc0033e4658d6f9d9952c3c0c6be3ec25bc2985 (diff)
downloadlinux-stable-9972e6b404884adae9eec7463e30d9b3c9a70b18.tar.gz
linux-stable-9972e6b404884adae9eec7463e30d9b3c9a70b18.tar.bz2
linux-stable-9972e6b404884adae9eec7463e30d9b3c9a70b18.zip
mmc: core: Fix kernel panic when remove non-standard SDIO card
SDIO tuple is only allocated for standard SDIO card, especially it causes memory corruption issues when the non-standard SDIO card has removed, which is because the card device's reference counter does not increase for it at sdio_init_func(), but all SDIO card device reference counter gets decreased at sdio_release_func(). Fixes: 6f51be3d37df ("sdio: allow non-standard SDIO cards") Signed-off-by: Matthew Ma <mahongwei@zeku.com> Reviewed-by: Weizhao Ouyang <ouyangweizhao@zeku.com> Reviewed-by: John Wang <wangdayu@zeku.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20221014034951.2300386-1-ouyangweizhao@zeku.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc/core')
-rw-r--r--drivers/mmc/core/sdio_bus.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c
index c6268c38c69e..babf21a0adeb 100644
--- a/drivers/mmc/core/sdio_bus.c
+++ b/drivers/mmc/core/sdio_bus.c
@@ -291,7 +291,8 @@ static void sdio_release_func(struct device *dev)
{
struct sdio_func *func = dev_to_sdio_func(dev);
- sdio_free_func_cis(func);
+ if (!(func->card->quirks & MMC_QUIRK_NONSTD_SDIO))
+ sdio_free_func_cis(func);
kfree(func->info);
kfree(func->tmpbuf);