diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2019-11-05 09:12:51 +0100 |
---|---|---|
committer | Richard Weinberger <richard@nod.at> | 2019-11-17 22:45:57 +0100 |
commit | f9c34bb529975fe9f85b870a80c53a83a3c5a182 (patch) | |
tree | 6a5cf84ad65ac0ed3499e10c68803d434b12a59d /drivers/mtd/ubi/wl.h | |
parent | 6abf57262166b4f4294667fb5206ae7ba1ba96f5 (diff) | |
download | linux-stable-f9c34bb529975fe9f85b870a80c53a83a3c5a182.tar.gz linux-stable-f9c34bb529975fe9f85b870a80c53a83a3c5a182.tar.bz2 linux-stable-f9c34bb529975fe9f85b870a80c53a83a3c5a182.zip |
ubi: Fix producing anchor PEBs
When a new fastmap is about to be written UBI must make sure it has a
free block for a fastmap anchor available. For this ubi_update_fastmap()
calls ubi_ensure_anchor_pebs(). This stopped working with 2e8f08deabbc
("ubi: Fix races around ubi_refill_pools()"), with this commit the wear
leveling code is blocked and can no longer produce free PEBs. UBI then
more often than not falls back to write the new fastmap anchor to the
same block it was already on which means the same erase block gets
erased during each fastmap write and wears out quite fast.
As the locking prevents us from producing the anchor PEB when we
actually need it, this patch changes the strategy for creating the
anchor PEB. We no longer create it on demand right before we want to
write a fastmap, but instead we create an anchor PEB right after we have
written a fastmap. This gives us enough time to produce a new anchor PEB
before it is needed. To make sure we have an anchor PEB for the very
first fastmap write we call ubi_ensure_anchor_pebs() during
initialisation as well.
Fixes: 2e8f08deabbc ("ubi: Fix races around ubi_refill_pools()")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'drivers/mtd/ubi/wl.h')
-rw-r--r-- | drivers/mtd/ubi/wl.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/wl.h b/drivers/mtd/ubi/wl.h index a9e2d669acd8..c93a53293786 100644 --- a/drivers/mtd/ubi/wl.h +++ b/drivers/mtd/ubi/wl.h @@ -2,7 +2,6 @@ #ifndef UBI_WL_H #define UBI_WL_H #ifdef CONFIG_MTD_UBI_FASTMAP -static int anchor_pebs_available(struct rb_root *root); static void update_fastmap_work_fn(struct work_struct *wrk); static struct ubi_wl_entry *find_anchor_wl_entry(struct rb_root *root); static struct ubi_wl_entry *get_peb_for_wl(struct ubi_device *ubi); |