diff options
| author | Jason Wang <jasowang@redhat.com> | 2022-06-17 15:29:49 +0800 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2022-06-27 08:02:59 -0400 |
| commit | 50c0ada627f56c92f5953a8bf9158b045ad026a1 (patch) | |
| tree | d31a4d46395675b1e007389063beb794bf910d2d /drivers/net/caif/caif_virtio.c | |
| parent | c346dae4f3fbce51bbd4f2ec5e8c6f9b91e93163 (diff) | |
| download | linux-stable-50c0ada627f56c92f5953a8bf9158b045ad026a1.tar.gz linux-stable-50c0ada627f56c92f5953a8bf9158b045ad026a1.tar.bz2 linux-stable-50c0ada627f56c92f5953a8bf9158b045ad026a1.zip | |
virtio-net: fix race between ndo_open() and virtio_device_ready()
We currently call virtio_device_ready() after netdev
registration. Since ndo_open() can be called immediately
after register_netdev, this means there exists a race between
ndo_open() and virtio_device_ready(): the driver may start to use the
device before DRIVER_OK which violates the spec.
Fix this by switching to use register_netdevice() and protect the
virtio_device_ready() with rtnl_lock() to make sure ndo_open() can
only be called after virtio_device_ready().
Fixes: 4baf1e33d0842 ("virtio_net: enable VQs early")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220617072949.30734-1-jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/net/caif/caif_virtio.c')
0 files changed, 0 insertions, 0 deletions