diff options
| author | Justin Stitt <justinstitt@google.com> | 2023-10-09 22:47:37 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-10-10 20:02:59 -0700 |
| commit | b0e4a14f5ba125be14a557ff3ac890ad0aacfc26 (patch) | |
| tree | 33bca16cb3e743729b097abd670b9ec2b2f39272 /drivers/net/dsa/realtek/rtl8365mb.c | |
| parent | 382bb32d3865ebe34e8b11e3117a8b3a3debddd3 (diff) | |
| download | linux-stable-b0e4a14f5ba125be14a557ff3ac890ad0aacfc26.tar.gz linux-stable-b0e4a14f5ba125be14a557ff3ac890ad0aacfc26.tar.bz2 linux-stable-b0e4a14f5ba125be14a557ff3ac890ad0aacfc26.zip | |
net: dsa: realtek: replace deprecated strncpy with ethtool_sprintf
`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this more robust and easier to
understand interface.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20231009-strncpy-drivers-net-dsa-realtek-rtl8366-core-c-v1-1-74e1b5190778@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/dsa/realtek/rtl8365mb.c')
0 files changed, 0 insertions, 0 deletions