diff options
| author | Michael Chan <michael.chan@broadcom.com> | 2023-04-16 23:58:18 -0700 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-04-18 12:27:15 +0200 |
| commit | e8b51a1a15d5a3cce231e0669f6a161dc5bb9b75 (patch) | |
| tree | cfdb097b6443f2655c3063428874356c133389e9 /drivers/net/ethernet/broadcom | |
| parent | e50b9b9e8610d47b7c22529443e45a16b1ea3a15 (diff) | |
| download | linux-stable-e8b51a1a15d5a3cce231e0669f6a161dc5bb9b75.tar.gz linux-stable-e8b51a1a15d5a3cce231e0669f6a161dc5bb9b75.tar.bz2 linux-stable-e8b51a1a15d5a3cce231e0669f6a161dc5bb9b75.zip | |
bnxt_en: Do not initialize PTP on older P3/P4 chips
The driver does not support PTP on these older chips and it is assuming
that firmware on these older chips will not return the
PORT_MAC_PTP_QCFG_RESP_FLAGS_HWRM_ACCESS flag in __bnxt_hwrm_ptp_qcfg(),
causing the function to abort quietly.
But newer firmware now sets this flag and so __bnxt_hwrm_ptp_qcfg()
will proceed further. Eventually it will fail in bnxt_ptp_init() ->
bnxt_map_ptp_regs() because there is no code to support the older chips.
The driver will then complain:
"PTP initialization failed.\n"
Fix it so that we abort quietly earlier without going through the
unnecessary steps and alarming the user with the warning log.
Fixes: ae5c42f0b92c ("bnxt_en: Get PTP hardware capability from firmware")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/ethernet/broadcom')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index c23e3b397bcf..ef97a4190b39 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -7627,7 +7627,7 @@ static int __bnxt_hwrm_ptp_qcfg(struct bnxt *bp) u8 flags; int rc; - if (bp->hwrm_spec_code < 0x10801) { + if (bp->hwrm_spec_code < 0x10801 || !BNXT_CHIP_P5_THOR(bp)) { rc = -ENODEV; goto no_ptp; } |