diff options
| author | Cai Huoqing <cai.huoqing@linux.dev> | 2023-03-23 17:03:07 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-03-24 09:09:28 +0000 |
| commit | 3228150ba688b8cddc7459e5ae9a09bc2d2e47be (patch) | |
| tree | 5e7fda89ca8a7aee97968411d86c352cd8c3340a /drivers/net/ethernet/ec_bhf.c | |
| parent | f686e9592734241eeddb406ef5f7aeab0a68c8b5 (diff) | |
| download | linux-stable-3228150ba688b8cddc7459e5ae9a09bc2d2e47be.tar.gz linux-stable-3228150ba688b8cddc7459e5ae9a09bc2d2e47be.tar.bz2 linux-stable-3228150ba688b8cddc7459e5ae9a09bc2d2e47be.zip | |
ethernet: ec_bhf: Remove redundant pci_clear_master
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ec_bhf.c')
| -rw-r--r-- | drivers/net/ethernet/ec_bhf.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c index 46e3a05e9582..c2c5c589a5e3 100644 --- a/drivers/net/ethernet/ec_bhf.c +++ b/drivers/net/ethernet/ec_bhf.c @@ -558,7 +558,6 @@ err_unmap: err_release_regions: pci_release_regions(dev); err_disable_dev: - pci_clear_master(dev); pci_disable_device(dev); return err; @@ -577,7 +576,6 @@ static void ec_bhf_remove(struct pci_dev *dev) free_netdev(net_dev); pci_release_regions(dev); - pci_clear_master(dev); pci_disable_device(dev); } |