summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/i40e
diff options
context:
space:
mode:
authorAlicja Kowalska <alicjax.kowalska@intel.com>2022-09-08 10:07:10 +0200
committerTony Nguyen <anthony.l.nguyen@intel.com>2022-11-02 09:26:18 -0700
commit30872d834bdbf20e12e3277394f85f1f4d7a9b3f (patch)
treeb29df4f4d490d29efc3e8ff11d77bc895e4100fa /drivers/net/ethernet/intel/i40e
parent6d4d584a7ea8fc8d2be77545cb503118c193738a (diff)
downloadlinux-stable-30872d834bdbf20e12e3277394f85f1f4d7a9b3f.tar.gz
linux-stable-30872d834bdbf20e12e3277394f85f1f4d7a9b3f.tar.bz2
linux-stable-30872d834bdbf20e12e3277394f85f1f4d7a9b3f.zip
i40e: Add appropriate error message logged for incorrect duplex setting
Nothing logged in dmesg for attempting to set incorrect duplex. Add appropriate error message logged for incorrect duplex setting. Signed-off-by: Alicja Kowalska <alicjax.kowalska@intel.com> Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com> Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40e')
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_ethtool.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index cc269f9db99f..616d27ec3226 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -1287,8 +1287,10 @@ static int i40e_set_link_ksettings(struct net_device *netdev,
* trying to set something that we do not support.
*/
if (memcmp(&copy_ks.base, &safe_ks.base,
- sizeof(struct ethtool_link_settings)))
+ sizeof(struct ethtool_link_settings))) {
+ netdev_err(netdev, "Only speed and autoneg are supported.\n");
return -EOPNOTSUPP;
+ }
while (test_and_set_bit(__I40E_CONFIG_BUSY, pf->state)) {
timeout--;